ci(json-schema-check): allow nested config paths #294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
json-schema-check
considers only specific files match:schema/<schema_cfg_name>.schema.json
andconfig/<schema_cfg_name>.param.yaml
. For packages with many config files, the config directory structure may differ. Even though the files follow naming convention, the sub directories are not taken into account. This small change in pull request adds following naming convention:schema/<schema_cfg_name>.schema.json
andconfig/<namespace>/<schema_cfg_name>.param.yaml
.Tests performed
Checked locally with CI script few test cases, success stands for
Validating ...
and fail stands forNo configuration files found for schema ...
or schema was not found.Current:${\color{green}SUCCESS}$ ${\color{green}SUCCESS}$
Proposed:
Current:${\color{red}FAIL}$ ${\color{green}SUCCESS}$
Proposed:
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.