Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(planning-design): update reference implementation diagram #485

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Nov 19, 2023

Description

  • Update planning diagram for the reference implementation
    • Add elastic_band_smoother node

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe TakaHoribe added component:planning Route planning, decision-making, and navigation. type:documentation Creating or refining documentation. labels Nov 19, 2023
@TakaHoribe TakaHoribe enabled auto-merge (squash) November 19, 2023 09:11
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The out_of_lane module is missing from the behavior_velocity_planner but it was also missing in the previous picture.
If you prefer I can add it in a separate PR.

@TakaHoribe TakaHoribe merged commit 4abe15c into autowarefoundation:main Nov 19, 2023
15 checks passed
@TakaHoribe TakaHoribe deleted the update-planning-arch-detailed branch November 19, 2023 09:25
@TakaHoribe
Copy link
Contributor Author

@maxime-clem Oops, sorry. It is merged by auto-merge. I hope you will add the out_of_lane in another PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. type:documentation Creating or refining documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants