Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration: Update migration with shared tpm case #5803

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

migration: Update migration with shared tpm case #5803

wants to merge 1 commit into from

Conversation

cliping
Copy link
Contributor

@cliping cliping commented Jul 24, 2024

Use the new directory instead of the swtpm directory as the path to store the image.

@cliping
Copy link
Contributor Author

cliping commented Jul 24, 2024

Test result:
(1/6) type_specific.io-github-autotest-libvirt.migration_with_vtpm.migration_with_shared_tpm.nfs.persistent_and_p2p: PASS (245.99 s)
(2/6) type_specific.io-github-autotest-libvirt.migration_with_vtpm.migration_with_shared_tpm.nfs.persistent_and_non_p2p: PASS (254.50 s)
(3/6) type_specific.io-github-autotest-libvirt.migration_with_vtpm.migration_with_shared_tpm.nfs.transient_and_non_p2p: PASS (230.78 s)
(4/6) type_specific.io-github-autotest-libvirt.migration_with_vtpm.migration_with_shared_tpm.ceph.persistent_and_p2p: PASS (362.99 s)
(5/6) type_specific.io-github-autotest-libvirt.migration_with_vtpm.migration_with_shared_tpm.ceph.persistent_and_non_p2p: PASS (362.67 s)
(6/6) type_specific.io-github-autotest-libvirt.migration_with_vtpm.migration_with_shared_tpm.ceph.transient_and_non_p2p: PASS (341.11 s)

@cliping cliping force-pushed the update-vtpm branch 4 times, most recently from 3671a13 to 28f1e9c Compare July 24, 2024 09:09
Yingshun
Yingshun reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@Yingshun Yingshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

libvirt/tests/src/migration/migration_with_vtpm/migration_with_shared_tpm.py Outdated
cmd = "mount -t ceph %s:6789:/ /var/lib/libvirt/swtpm -o name=admin" % mon_host
if not os.path.exists(swtpm_path):
os.mkdir(swtpm_path)
cmd = "mount -t ceph %s:6789:/ %s -o name=admin,secret=%s" % (mon_host, swtpm_path, ceph_key)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you plz reuse utils_disk.mount() instead of shell command line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks.

libvirt/tests/src/migration/migration_with_vtpm/migration_with_shared_tpm.py Outdated
Comment on lines 246 to 247
cmd = "umount /var/lib/libvirt/swtpm"
process.run(cmd, ignore_status=False, shell=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about reusing utils_disk.umount()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks.

@cliping cliping force-pushed the update-vtpm branch 2 times, most recently from 55bb025 to bd54110 Compare July 29, 2024 12:14
@cliping cliping force-pushed the update-vtpm branch 2 times, most recently from 2d57bbe to 4615d46 Compare January 2, 2025 01:47
@cliping
migration: Update migration with shared tpm case
b103b56 
Use the new directory instead of the swtpm directory as the path to
store the image.

Signed-off-by: lcheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yingshun Yingshun Yingshun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cliping @Yingshun