backingchain/snapshot_blockpull: fix disk disovery #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@chunfuwen please help review |
smitterl
force-pushed
the
snapshot_blockpull
branch
from
301a2ea to
ce9443e
Compare
Yingshun
reviewed
Feb 6, 2024
| @@ -359,7 +353,11 @@ def start_middletotop_blkpull_on_vm(): | |||
| setup_nbd_env(params) | |||
| try: | |||
| vm.start() | |||
| vm.wait_for_login().close() | |||
There was a problem hiding this comment.
I think we'd better to wait for vm login for other non-additional_disk scenarios, I mean keep this line for others. what do you think?
There was a problem hiding this comment.
@Yingshun Updated (s. following lines)
JOB ID : b7a6f92be4e4aabd7060fa4faf68248b7420fbd9
JOB LOG : /var/lib/avocado/job-results/job-2024-02-21T10.09-b7a6f92/job.log
(1/9) type_specific.io-github-autotest-libvirt.virtual_disks.snapshot_blockpull.positive_test.auth_backend_test.native_path.middle_to_top_to_base: PASS (63.55 s)
(2/9) type_specific.io-github-autotest-libvirt.virtual_disks.snapshot_blockpull.positive_test.block_backend_test.native_path.middle_to_top: PASS (38.42 s)
(3/9) type_specific.io-github-autotest-libvirt.virtual_disks.snapshot_blockpull.positive_test.file_backend_test.native_path.async: PASS (35.63 s)
(4/9) type_specific.io-github-autotest-libvirt.virtual_disks.snapshot_blockpull.positive_test.file_backend_test.native_path.bandwidth: PASS (30.31 s)
(5/9) type_specific.io-github-autotest-libvirt.virtual_disks.snapshot_blockpull.positive_test.file_backend_test.native_path.timeout: PASS (29.71 s)
(6/9) type_specific.io-github-autotest-libvirt.virtual_disks.snapshot_blockpull.positive_test.file_backend_test.native_path.middle_to_top: PASS (29.41 s)
(7/9) type_specific.io-github-autotest-libvirt.virtual_disks.snapshot_blockpull.positive_test.file_backend_test.reuse_external.keep_relative: PASS (30.21 s)
(8/9) type_specific.io-github-autotest-libvirt.virtual_disks.snapshot_blockpull.positive_test.nbd_backend_test.native_path.base_to_top: PASS (31.17 s)
(9/9) type_specific.io-github-autotest-libvirt.virtual_disks.snapshot_blockpull.positive_test.nbd_backend_test.native_path.middle_to_top: PASS (30.77 s)
RESULTS : PASS 9 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /var/lib/avocado/job-results/job-2024-02-21T10.09-b7a6f92/results.html
JOB TIME : 319.78 s
ce9443e to
061336c
Compare
The test identified new disks by their target name. However, a reboot can mess up the non-persistent disk namings /dev/vdX. Use instead a function that identifies a new disk inside of a VM as the one disk that has no root mount on itself, its partitions or volumes. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
snapshot_blockpull
branch
from
061336c to
db3d2f4
Compare
Yingshun
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test identified new disks by their target name. However, a reboot can mess up the non-persistent disk namings /dev/vdX.
Use instead a function that identifies a new disk inside of a VM as the one disk that has no root mount on itself, its partitions or volumes.