add case for dimm memory with access and discard setting #5328

nanli1 · 2023-12-08T14:54:28Z

xxxx-299048:Dimm memory device with access and discard settings

Signed-off-by: nanli [email protected]

x86+rhel9 & rhel8

avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 memory.devices.dimm.access_and_discard
 (1/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.undefined.file: PASS (131.14 s)
 (2/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.undefined.anonymous: PASS (130.06 s)
 (3/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.undefined.memfd: PASS (127.07 s)
 (4/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.shared_and_discard.file: PASS (130.73 s)
 (5/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.shared_and_discard.anonymous: PASS (127.75 s)
 (6/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.shared_and_discard.memfd: PASS (126.44 s)
 (7/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.private_and_no_discard.file: PASS (126.11 s)
 (8/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.private_and_no_discard.anonymous: PASS (127.82 s)
 (9/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.private_and_no_discard.memfd: PASS (124.00 s)

aarm+rhel9

 avocado run --vt-type libvirt --test-runner=runner --vt-machine-type arm64-mmio memory.devices.dimm.access_and_discard
 (1/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.undefined.file: PASS (267.42 s)
 (2/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.undefined.anonymous: PASS (264.22 s)
 (3/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.undefined.memfd: PASS (264.65 s)
 (4/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.shared_and_discard.file: PASS (264.61 s)
 (5/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.shared_and_discard.anonymous: PASS (267.70 s)
 (6/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.shared_and_discard.memfd: PASS (265.65 s)
 (7/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.private_and_no_discard.file: PASS (260.87 s)
 (8/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.private_and_no_discard.anonymous: PASS (264.70 s)
 (9/9) type_specific.io-github-autotest-libvirt.memory.devices.dimm.access_and_discard.with_numa.private_and_no_discard.memfd: PASS (264.61 s)

cliping

Others LGTM

cliping · 2023-12-14T13:46:44Z

libvirt/tests/src/memory/memory_devices/dimm_memory_with_access_and_discard.py

+from virttest.utils_libvirtd import Libvirtd
+
+
+def get_vm_attrs(test, params):


The same function is in #5290. Maybe we can move this function to provide/memory/memory_base.py. What do you think?

Thanks liping , Good idea. Currently , It's not very common for all the cases , only suitable for these two prs, Could I move it if exists more usage ?

dzhengfy · 2024-01-30T04:21:27Z

libvirt/tests/src/memory/memory_devices/dimm_memory_with_access_and_discard.py

+def get_vm_attrs(test, params):
+    """
+    Get vm attrs.
+    :param test: test object


Add a blank line above this line

Thanks dzheng, Done

dzhengfy · 2024-01-30T04:23:04Z

libvirt/tests/cfg/memory/memory_devices/dimm_memory_with_access_and_discard.cfg

+    variants memory_backing:
+        - file:
+            source_type = 'file'
+            source_attr = "'source_type':'${source_type}'"


Move this line and all same occurences below to line 53

Thanks dzheng, Done

dzhengfy · 2024-01-30T04:28:37Z

libvirt/tests/src/memory/memory_devices/dimm_memory_with_access_and_discard.py

+    return vm_attrs
+
+
+def get_dimm_mem(test, params):


This function is to create a list of memory devices xml. So let's make the name accurate, like create_dimm_mem_list()

Thanks dzheng, Done

dzhengfy · 2024-01-30T04:35:21Z

libvirt/tests/src/memory/memory_devices/dimm_memory_with_access_and_discard.py

+
+        test.log.info("TEST_STEP5: Hot unplug all dimm memory device")
+        for mem in all_dimms:
+            dimm = memory.Memory()


There is no need to create new objects again for hotunplugging, I think.
We could put dimm in line 150 to a list and reuse them here.

Thanks dzheng, Done

dzhengfy · 2024-01-30T04:41:27Z

libvirt/tests/src/memory/memory_devices/dimm_memory_with_access_and_discard.py

+        dimm device.
+        """
+        test.log.info("TEST_STEP1: Define vm with dimm memory")
+        vmxml = vm_xml.VMXML.new_from_inactive_dumpxml(vm_name)


It is duplicated with line 207 original_xml = vm_xml.VMXML.new_from_inactive_dumpxml(vm_name)

hi dzheng,Thanks for your comment. L144 is used for step1, original_xml is used for step8

dzhengfy · 2024-01-30T04:45:01Z

libvirt/tests/src/memory/memory_devices/dimm_memory_with_access_and_discard.py

+            test.fail("Expected '%s', but got '%s'" % (path_error, res))
+
+        test.log.info("TEST_STEP8: Define guest without any dimm memory")
+        original_xml.setup_attrs(**vm_attrs)


I do not understand why we use vm_attrs to configure vm xml?
Is it required attributes?
And could we make sure original_xml has no dimm memory device? If not, we need explicitly to remove existing dimm device if any.

Hi dzheng, Thanks your comment. For these two questions:

vm_attrs should be used to define required attributes as the polarion case

Done , Removed dimm

dzhengfy · 2024-01-30T04:46:45Z

libvirt/tests/src/memory/memory_devices/dimm_memory_with_access_and_discard.py

+
+        test.log.info("TEST_STEP9: Hot plug all dimm memory device")
+        for mem in all_dimms:
+            dimm = memory.Memory()


Reuse above created memory device objects.

Thanks dzheng, Done

xxxx-299048:Dimm memory device with access and discard settings Signed-off-by: nanli <[email protected]>

dzhengfy

LGTM

nanli1 marked this pull request as draft December 8, 2023 14:54

nanli1 force-pushed the add_case_for_dimm_with_access_discard_setting branch 4 times, most recently from ff7ac0a to caf9c33 Compare December 13, 2023 09:12

nanli1 marked this pull request as ready for review December 13, 2023 09:16

nanli1 marked this pull request as draft December 13, 2023 09:59

nanli1 marked this pull request as ready for review December 13, 2023 11:49

cliping reviewed Dec 14, 2023

View reviewed changes

nanli1 requested a review from cliping December 18, 2023 02:53

cliping approved these changes Jan 16, 2024

View reviewed changes

dzhengfy reviewed Jan 30, 2024

View reviewed changes

nanli1 force-pushed the add_case_for_dimm_with_access_discard_setting branch from caf9c33 to a0c7cf6 Compare February 4, 2024 01:37

add case for dimm memory with access and discard setting

fc2ea57

xxxx-299048:Dimm memory device with access and discard settings Signed-off-by: nanli <[email protected]>

nanli1 force-pushed the add_case_for_dimm_with_access_discard_setting branch from a0c7cf6 to fc2ea57 Compare February 4, 2024 01:48

nanli1 requested a review from dzhengfy February 4, 2024 02:01

dzhengfy approved these changes Feb 19, 2024

View reviewed changes

dzhengfy merged commit fa5a7a0 into autotest:master Feb 19, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add case for dimm memory with access and discard setting #5328

add case for dimm memory with access and discard setting #5328

nanli1 commented Dec 8, 2023 •

edited

Loading

cliping left a comment

cliping Dec 14, 2023

nanli1 Dec 18, 2023

dzhengfy Jan 30, 2024

nanli1 Feb 4, 2024

dzhengfy Jan 30, 2024

nanli1 Feb 4, 2024

dzhengfy Jan 30, 2024

nanli1 Feb 4, 2024

dzhengfy Jan 30, 2024

nanli1 Feb 4, 2024

dzhengfy Jan 30, 2024

nanli1 Feb 4, 2024

dzhengfy Jan 30, 2024

nanli1 Feb 4, 2024 •

edited

Loading

dzhengfy Jan 30, 2024

nanli1 Feb 4, 2024

dzhengfy left a comment

		from virttest.utils_libvirtd import Libvirtd


		def get_vm_attrs(test, params):

add case for dimm memory with access and discard setting #5328

add case for dimm memory with access and discard setting #5328

Conversation

nanli1 commented Dec 8, 2023 • edited Loading

cliping left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nanli1 Feb 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dzhengfy left a comment

Choose a reason for hiding this comment

nanli1 commented Dec 8, 2023 •

edited

Loading

nanli1 Feb 4, 2024 •

edited

Loading