Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virt_admin_logouts.positive_test.libvirtd_virt_admin_log_output failure #5292

Merged

Conversation

chunfuwen
Copy link
Contributor

Fix virt_admin_logouts.positive_test.libvirtd_virt_admin_log_output failure

The expected result diffs in different rhel version

…ase failure

The expected result diffs in different rhel version

Signed-off-by: chunfuwen <[email protected]>
@chunfuwen
Copy link
Contributor Author

PASS 1-type_specific.io-github-autotest-libvirt.conf_file.libvirtd_conf.virt_admin_logging.positive_test.journal_virt_admin_log_output
PASS 2-type_specific.io-github-autotest-libvirt.conf_file.libvirtd_conf.virt_admin_logging.positive_test.libvirtd_virt_admin_log_output

@chunfuwen
Copy link
Contributor Author

Before:

previous failure log
FAIL 1-type_specific.io-github-autotest-libvirt.conf_file.libvirtd_conf.virt_admin_logging.positive_test.libvirtd_virt_admin_log_output -> TestFail: Can not find expected log output: 3:journald from virt admin command output: Logging outputs: 3:stderr

@chunfuwen
Copy link
Contributor Author

@hs0210
@yanqzhan
please help check it

Copy link
Contributor

@hs0210 hs0210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works well on xx-8

Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzhengfy
Copy link
Contributor

dzhengfy commented Dec 3, 2023

It seems no need fetaure owner to review as this fix is obvious.

@dzhengfy dzhengfy merged commit 5047222 into autotest:master Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants