Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual_network: Add a case about mem_lock limit for vm with multiple… #5270

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

Yingshun
Copy link
Contributor

… vdpa interfaces

This PR adds:
VIRT-296169 - [vdpa] Check the mem_lock limit when start vm
with multiple vdpa interfaces

Test results:
(1/1) type_specific.io-github-autotest-libvirt.virtual_network.locked_memory.vdpa_interfaceiface.multiple_interfaces: PASS (111.34 s)

@Yingshun Yingshun requested a review from chloerh November 10, 2023 10:50
Copy link
Contributor

@cliping cliping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iface_dev = interface_base.create_iface(dev_type, iface_dict)
libvirt.add_vm_device(vm_xml.VMXML.new_from_dumpxml(vm_name),
iface_dev)
test.log.debug("VM xml afater updating ifaces: %s.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated. thx!

… vdpa interfaces

This PR adds:
    VIRT-296169 - [vdpa] Check the mem_lock limit when start vm
        with multiple vdpa interfaces

Signed-off-by: Yingshun Cui <[email protected]>
@chloerh chloerh merged commit 496ff4c into autotest:master Nov 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants