Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration: Add listen address case #5237

Merged
merged 1 commit into from
Dec 13, 2023
Merged

migration: Add listen address case #5237

merged 1 commit into from
Dec 13, 2023

Conversation

cliping
Copy link
Contributor

@cliping cliping commented Oct 30, 2023

VIRT-297874 - VM live migration with copy storage - network data transport - TCP - --listen-address

@cliping
Copy link
Contributor Author

cliping commented Oct 30, 2023

Test result:

(01/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_all.target_ipv4_address.p2p: PASS (222.59 s)
(02/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_all.target_ipv4_address.non_p2p: PASS (225.27 s)
(03/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_all.target_ipv6_address.p2p: PASS (225.69 s)
(04/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_all.target_ipv6_address.non_p2p: PASS (225.75 s)
(05/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_all.all_ipv4.p2p: PASS (225.84 s)
(06/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_all.all_ipv4.non_p2p: PASS (225.18 s)
(07/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_all.all_ipv6.p2p: PASS (225.23 s)
(08/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_all.all_ipv6.non_p2p: PASS (223.43 s)
(09/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_all.invalid_address.p2p: PASS (203.08 s)
(10/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_all.invalid_address.non_p2p: PASS (201.99 s)
(11/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_inc.target_ipv4_address.p2p: PASS (225.87 s)
(12/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_inc.target_ipv4_address.non_p2p: PASS (225.30 s)
(13/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_inc.target_ipv6_address.p2p: PASS (225.69 s)
(14/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_inc.target_ipv6_address.non_p2p: PASS (225.99 s)
(15/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_inc.all_ipv4.p2p: PASS (226.13 s)
(16/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_inc.all_ipv4.non_p2p: PASS (225.89 s)
(17/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_inc.all_ipv6.p2p: PASS (224.74 s)
(18/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_inc.all_ipv6.non_p2p: PASS (223.21 s)
(19/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_inc.invalid_address.p2p: PASS (201.91 s)
(20/20) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.network_data_transport.tcp_listen_address.copy_storage_inc.invalid_address.non_p2p: PASS (202.84 s)

Yingshun
Yingshun reviewed Oct 31, 2023
View reviewed changes
provider/migration/migration_base.py Outdated
@@ -726,3 +726,14 @@ def get_vm_serial_session_on_dest(params):
vm_session = migration_obj.vm.wait_for_serial_login(timeout=120)
params.update({"vm_session": vm_session})
migration_obj.vm.connect_uri = backup_uri


def check_listen_address(params):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be used by other tests? how about moving to avocado-vt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks.

@cliping cliping mentioned this pull request Dec 6, 2023
Merged
@cliping
Copy link
Contributor Author

cliping commented Dec 6, 2023

Depend on: avocado-framework/avocado-vt#3809

@cliping
migration: Add listen address case
bebb55e 
VIRT-297874 - VM live migration with copy storage - network data
transport - TCP - --listen-address

Signed-off-by: lcheng <[email protected]>
@Yingshun Yingshun added the depend on The PR has dependency on other PRs label Dec 6, 2023
@chloerh chloerh self-requested a review December 7, 2023 02:45
@chloerh chloerh merged commit 44c51c4 into autotest:master Dec 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chloerh chloerh chloerh approved these changes

@Yingshun Yingshun Yingshun approved these changes

Assignees
No one assigned
Labels
depend on The PR has dependency on other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cliping @chloerh @Yingshun