Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traceroute: Fix test to set time delay between probes. #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Open

Traceroute: Fix test to set time delay between probes. #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions linux-tools/traceroute/traceroute.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ function run_test()
# If this is the only test that passes for a system, then we can guess
# that there is some system in the probe path that expects some delay
# between probes
sleep 05
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, if you can add a waiting function for a certain system condition, that's always better than a flat sleep. Can you do that in this case?

tc_register "Set time delay between probes"
traceroute -z 300 $dest_host|sed "1 d"|awk '{print $2}' 1>$stdout 2>$stderr
grep -q $dest_host $stdout
Expand Down