-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taurus storage migration for "Private EVM" #3360
Draft
teor2345
wants to merge
12
commits into
evm-obj-minor-cleanups
Choose a base branch
from
private-evm-taurus-migration
base: evm-obj-minor-cleanups
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+309
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: linning <[email protected]>
Signed-off-by: linning <[email protected]>
Add storage migration for `Operator` struct change and bump runtime version
This was referenced Jan 27, 2025
29655a9
to
a425f09
Compare
ee8c646
to
eb4e295
Compare
a425f09
to
8fa2e15
Compare
teor2345
commented
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is up to date, but the diff will be a bit confusing until #3350 merges, and we merge those changes into the taurus-runtime-upgrades
…vate-evm-taurus-migration Remove completed VersionCheckedMigrateDomainsV1ToV2, Combine: - VersionCheckedMigrateDomainsV0ToV1 (actually messenger) - VersionCheckedMigrateDomainsV2ToV3
This reverts commit 06d7a04, except for changes that have already been overwritten.
a1a70ee
to
eb2daee
Compare
f70a549
to
c0aa066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
main
main
intotaurus-runtime-upgrade
evm-tracker
storage during the migrationtaurus-runtime-upgrade
How to review this PR
This PR is part of a series of PRs which add "private EVM" functionality to subspace. It upgrades the existing Taurus storage format for this feature. (Mainnet doesn't need an upgrade, because it doesn't have any EVMs deployed.)
This PR also reverts the migration in #3342 (except for some changes which have already been overwritten).
The PR diff includes these changes, which can be ignored (they will disappear when this PR is rebased):
migrations
module andVersionCheckedMigrateDomainsV0ToV1
typeThe previous PR in this series is #3350, which adds this feature to Mainnet.
What it does
This PR upgrades the domain registry storage into a new format which stores the initial contract creation allow list.
It also merges all the changes in #3350 into the
taurus-runtime-upgrades
branch.Code contributor checklist: