Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify docs CI #3343

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Simplify docs CI #3343

merged 1 commit into from
Jan 12, 2025

Conversation

nazar-pc
Copy link
Member

cargo-docs was mostly, but not exactly, duplicate of rustdoc.

This makes use of rustdoc by default, just skips deployment unless pushed into main, while cargo-docs is removed as no longer necessary.

Code contributor checklist:

@nazar-pc nazar-pc requested a review from teor2345 as a code owner January 12, 2025 21:37
teor2345
teor2345 approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@nazar-pc nazar-pc added this pull request to the merge queue Jan 12, 2025
Merged via the queue into main with commit e0a3f16 Jan 12, 2025
8 checks passed
@nazar-pc nazar-pc deleted the simplify-docs-ci branch January 12, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nazar-pc @teor2345