-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore removal of old addresses #2244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is actually problematic and will be fixed once we upgrade to libp2p/rust-libp2p#4596
Example above is a complete mess, identify doesn't return external addresses for some reason, some of the Kademlia addresses are with and some without |
Checking strings is not the most efficient solution, but it is the most compact and shouldn't be a huge bottleneck |
multiformats/rust-multiaddr#105 once resolved will help to avoid dealing with strings |
I was supposed to restore it before merging #2242.
Restored version has filtering condition flipped (that was a bug in the old version that had to be corrected).
Code contributor checklist: