-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swift: allow specifying text encoding at document creation #206
swift: allow specifying text encoding at document creation #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've requested a few minor nits/changes in documentation wording for clarity, all as suggested changes. Additionally, I'd like to make sure that the exposed TextEncoding enum is documented through to the external Swift API that it's clear how those values related to Swift encodings.
The tests are the real gem of this PR - thank you - illustrating nicely how the text encoding changes effect cursor positions, etc.
What, exactly, is this holding on before we can/should merge this? Is there an upstream PR that's pending, or is that yet to be established?
Co-authored-by: Joseph Heck <[email protected]>
Co-authored-by: Joseph Heck <[email protected]>
Good call. Added Swift type and API documentation about
Exactly. This PR exposes changes done in upstream PR related to TextEncoding, |
@heckj requested your review because I changed the side note: PR is ready to merge. |
Related pull-requests:
What is the goal?
Exposes new Automerge TextEncoding flag for creation of documents. It enables us to define the text representation to use in each of the operations without being forced to use
Unicode Scalars
in Swift.blockers: pending to merge related PRs, and bump automerge core.