Fix multiple matching filters with different sizes #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiphopotamus
force-pushed
the
master
branch
4 times, most recently
from
5fb4b32 to
76c7804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two or more filters have different size ranges but both match an announcement, if the filter with the non-matching size is evaluated first, the announcement will fail to match. It will never be evaluated against any subsequent matches which might have an acceptable size.
This change will cause the filters to be re-evaluated after the torrent has been download in the case that the size fails to match.
Fixes #201
I didn't see #202 when I made this, but this is an alternative approach which only needs to download the torrent once.