fix(pkce): session generated needlessly #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-elliott
force-pushed
the
fix-pkce
branch
from
e7cdbbf to
e74198b
Compare
This fixes an issue where the PKCE session is generated when not required. This also avoids a particular error that can occur in some situations.
james-d-elliott
force-pushed
the
fix-pkce
branch
from
e74198b to
e206aba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the PKCE session is generated when not required. This also avoids a particular error that can occur in some situations. In addition it ensures the usage of subtle for comparing PKCE verifiers and challenges.