Added slave propagation to mountns which allows snaps to function. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to ensure their mounts are visible in the mount namespace.
brian-doherty
changed the title
|
This is great, thanks for working on this. I was having a problem #12 that snap wipes out my mount namespaces when I run e.g. snap Firefox in nsdo. I just tried this PR, and I'm still having that problem. Is this PR moreso for fixing snapd failing to start, or something like that? |
|
Yeah this allows snaps to start, but you're right that the snap doesn't
pick up the nsdo mount ns. Have not solved that one. It will for example
screw up your DNS.
…On Thu, Jun 16, 2022, 7:38 AM Austin Adams ***@***.***> wrote:
This is great, thanks for working on this.
I was having a problem #12 <#12>
that snap wipes out my mount namespaces when I run e.g. snap Firefox in
nsdo. I just tried this PR, and I'm still having that problem. Is this PR
moreso for fixing snapd failing to start, or something like that?
—
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASFD42NAJ77CWW7GPP3B6O3VPNC5ZANCNFSM5V3O3FBQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I opened a thread here, let's see what happens: https://forum.snapcraft.io/t/snaps-interfere-with-mount-namespaces/30512 But for this issue: would you mind sharing some steps to reproduce? Sorry, not trying to be annoying, but I'm curious and want to learn more about these things |
|
If you open Firefox and then open a file in /etc that's supposed to be
shadowed, you'll see that you get the main /etc time instead.
…On Thu, Jun 16, 2022, 3:13 PM Austin Adams ***@***.***> wrote:
I opened a thread here, let's see what happens:
https://forum.snapcraft.io/t/snaps-interfere-with-mount-namespaces/30512
But for this issue: would you mind sharing some steps to reproduce? Sorry,
not trying to be annoying, but I'm curious and want to learn more about
these things
—
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASFD42MEWOUPPJNFOE2PKGLVPOYJDANCNFSM5V3O3FBQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Forgive me for my slow responses sir, what are the steps to reproduce the problem this is fixing? Is it starting snapd before or after the |
|
I'm not sure it matters when snapd starts. When you run a snap it creates a
new mount namespace at that time and it does not include the nsdo mount
namespace. Here's how I can reproduce:
1) Start firefox via nsdo.
2) Open a file that is supposed to be shadowed, e.g. file:///etc/hosts
3) You will get the main FS version instead of the netns version.
B
…On Fri, Jul 8, 2022 at 9:51 AM Austin Adams ***@***.***> wrote:
Forgive me for my slow responses sir, what are the steps to reproduce the
problem this is fixing?
Is it starting snapd before or after the ***@***.*** unit? I'm new to snaps
and very curious
—
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASFD42NRTNOXMO3RDFTVKUDVTA57BANCNFSM5V3O3FBQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Oh wow, so this PR fixes that? Or are we talking about something different? |
|
No, that is still an outstanding issue that I have not figured out how to
deal with. I tried changing the propagation but that caused other problems.
B
…On Fri, Jul 8, 2022 at 10:05 AM Austin Adams ***@***.***> wrote:
Oh wow, so this PR fixes that? Or are we talking about something different?
—
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASFD42OL5HEDXG75RR2MJG3VTA7T5ANCNFSM5V3O3FBQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added slave propagation to mountns which allows snaps to function.