unable to rename node module

[jdanyow]

aurelia/animator-velocity#13

Renaming the npm package "velocity-animate" to "velocity" breaks the build.

[EisenbergEffect]

@jdanyow Do you know what version of the CLI you had this issue with? I thought we enabled this at some point but I'm not sure.

[jdanyow]

re-tested with 0.18.0, still seems to be an issue.

To test:

npm install aurelia-animator-velocity

aurelia.json

          "aurelia-animator-velocity",
          "jquery",
          {
            "name": "velocity",
            "path": "../node_modules/velocity-animate",
            "main": "velocity",
            "deps": ["jquery"],
            "resources": ["velocity.ui.js"]
          }

Workaround: aurelia/animator-velocity#13 (comment)

[EisenbergEffect]

The latest CLI is 0.20.1 Can you try that?

On Sep 30, 2016 2:25 AM, "Jeremy Danyow" [email protected] wrote:

re-tested with 0.18.0, still seems to be an issue.

To test:

npm install aurelia-animator-velocity

aurelia.json

      "aurelia-animator-velocity",
      "jquery",
      {
        "name": "velocity",
        "path": "../node_modules/velocity-animate",
        "main": "velocity",
        "deps": ["jquery"],
        "resources": ["velocity.ui.js"]
      }

Workaround: aurelia/animator-velocity#13 (comment)
aurelia/animator-velocity#13 (comment)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#309 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIBna1ZmtJqNUF_HpAAC8dt17cdaKYyks5qvNWMgaJpZM4J4otT
.

[DarienFord]

This is still broken.

[simonfox]

I am running into this just now (moving an app from JSPM to CLI). I would be happy to spend some time looking at it if somebody could give me some guidance?

cc @EisenbergEffect

[EisenbergEffect]

@JeroenVinke is the best person to provide guidance on this issue.

[JeroenVinke]

Now that I think of it, #589 will allow us to alias modules because it enables the use of the map property in the requirejs config:

"map": {
    "*": {
      "my-renamed-package": "my-package"
    }
  },

[jpravetz]

I was looking to see if, at this date, there was a less-kludgy way to include aurelia-animator-velocity when using the latest CLI. It looks like the module map suggestion #589 by @JeroenVinke has been put on hold, and so the shim workaround in #13 remains our only solution. Please correct me if I am wrong.

[zewa666]

@huochunpeng this should be resolved with the new auto-tracer right?

[3cp]

Yes, it should be fixed by new tracer. BTW, requirejs config map is not supported anymore, because new tracer doesn't use requirejs runtime to help tracing.

[3cp]

I have to point out while rename generally works, it is not enough for this velocity case.

aurelia-animator-velocity requires velocity-animator/velocity.ui, then velocity-animator/velocity.ui requires velocity (resulting to search npm package velocity) instead of ./velocity.

Both velocity-animate and velocity has to point to the same package. So aurelia/animator-velocity#13 (comment) is the only working workaround.