classes that generate an error should not be part of the class map at…

… all
auraphp · Sep 17, 2024 · 4f431fe · 4f431fe
1 parent f43da38
commit 4f431fe
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/src/ClassScanner/ComposerMapGenerator.php b/src/ClassScanner/ComposerMapGenerator.php
@@ -52,11 +52,9 @@ private function convertToClassMap(ClassMap $classMap, array $composerMap): Clas
 
             try {
                 $attributes = [...$this->reflector->yieldAttributes($class)];
+                $classMap->addClass(new ClassSpecification($class, $path, $attributes));
             } catch (\Error) {
-                $attributes = [];
             }
-
-            $classMap->addClass(new ClassSpecification($class, $path, $attributes));
         }
 
         return $classMap;

diff --git a/tests/ClassScanner/ComposerMapGeneratorTest.php b/tests/ClassScanner/ComposerMapGeneratorTest.php
@@ -4,6 +4,8 @@
 
 namespace Aura\Di\ClassScanner;
 
+use Aura\Di\Fake\FakeAllAttributes;
+use Aura\Di\Fake\FakeClassExtendsNonExistent;
 use PHPUnit\Framework\TestCase;
 
 class ComposerMapGeneratorTest extends TestCase
@@ -37,6 +39,8 @@ public function testAddingClass()
         $newClassName = 'CacheTest\\NewFile' . $classSuffix;
 
         $classMap = $generator->generate();
+        $this->assertTrue($classMap->hasClass(FakeAllAttributes::class));
+        $this->assertFalse($classMap->hasClass(FakeClassExtendsNonExistent::class));
         $this->assertNotContains($newClassName, $classMap->getClasses());
 
         $newFile = $this->createRandomClassFile($newClassName);

diff --git a/tests/Fake/FakeClassExtendsNonExistent.php b/tests/Fake/FakeClassExtendsNonExistent.php
@@ -0,0 +1,6 @@
+<?php
+namespace Aura\Di\Fake;
+
+class FakeClassExtendsNonExistent extends NonExistent
+{
+}