Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.2.1 #170

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Release 1.2.1 #170

merged 1 commit into from
Mar 27, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Mar 27, 2024

image

@hagenw hagenw requested a review from maxschmitt March 27, 2024 15:05
maxschmitt
maxschmitt approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@maxschmitt maxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds clear to me, though I am not a big fan of changing default parameters.

@hagenw
Copy link
Member Author

hagenw commented Mar 27, 2024

though I am not a big fan of changing default parameters.

Yes, this is indeed not a good idea. In this case it was announced ~1 year ago with a deprecation warning, that the default will change with version 1.2.0 of audinterface, but I forgot to do it. Hence it is included in this bug fix release.

@hagenw hagenw merged commit bdb078c into main Mar 27, 2024
16 checks passed
@hagenw hagenw deleted the release-1.2.1 branch March 27, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxschmitt maxschmitt maxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hagenw @maxschmitt