-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update syntax to Python >=3.9 #463
Conversation
Reviewer's Guide by SourceryThis pull request updates the code to use Python 3.9+ syntax, replacing Class diagram showing updated type hints in Table classclassDiagram
class Table {
+media() Media|None
+split() Split|None
+drop_columns(column_ids: str|Sequence[str], inplace: bool) Self
+extend_index(index: Index, fill_values: object|dict[str, object]) Self
+get(index: Index, map: dict[str, str|Sequence[str]]) DataFrame
+pick_columns(column_ids: str|Sequence[str]) Self
+set(values: dict[str, Values]|DataFrame)
+update(others: Self|Sequence[Self]) Self
-_levels_and_dtypes() dict[str, str]
}
note for Table "Updated type hints to use Python 3.9+ syntax with | operator"
Class diagram showing updated type hints in Column classclassDiagram
class Column {
+rater() Rater|None
+scheme() Scheme|None
+get(as_segmented: bool, allow_nat: bool, num_workers: int|None) Series
+__eq__(other: Column) bool
}
note for Column "Updated type hints to use Python 3.9+ syntax with | operator"
Class diagram showing updated type hints in Scheme classclassDiagram
class Scheme {
+is_numeric() bool
+labels_as_list() list
-_labels_to_dict(labels: dict|list|str) dict
-_labels_to_list(labels: dict|list|str) list
}
note for Scheme "Updated type hints to use built-in list and dict types"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
Updates syntax to Python >=3.9 by removing the use of
typing
(with the exception oftyping.Self
inaudformat/core/table.py
type alias definitions inaudformat/core/typing.py
, andtyping.TYPE_CHECKING
inaudformat/core/column.py
).Summary by Sourcery
Enhancements:
typing
library.