Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Switch to new backend structure #305

Closed
wants to merge 19 commits into from
Closed

WIP: Switch to new backend structure #305

wants to merge 19 commits into from

Conversation

frankenjoe
Copy link
Collaborator

@frankenjoe frankenjoe commented May 9, 2023

Apply necessary changes to audb in order to use the new backend structure that will be introduced with audackend>=1.0.0, see audeering/audbackend#76

@frankenjoe frankenjoe changed the base branch from main to dev May 9, 2023 06:34
@frankenjoe frankenjoe requested a review from hagenw May 9, 2023 06:36
@frankenjoe
Copy link
Collaborator Author

frankenjoe commented May 9, 2023

@hagenw

* It seems that actions are currently not run when setting dev as target branch.

  • Building the docs and running the docstring examples are disabled until we have a published version of emodb with the new structure
  • There are two more TODOs related to the tests, we need to fix

Otherwise transition seems straight-forward.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #305 (f946c47) into dev (3d1a20a) will decrease coverage by 1.7%.
The diff coverage is 75.8%.

Impacted Files Coverage Δ
audb/core/conftest.py 0.0% <0.0%> (-100.0%) ⬇️
audb/core/api.py 100.0% <100.0%> (ø)
audb/core/load.py 100.0% <100.0%> (ø)
audb/core/load_to.py 100.0% <100.0%> (ø)
audb/core/publish.py 100.0% <100.0%> (ø)
audb/core/utils.py 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@hagenw
Copy link
Member

hagenw commented May 9, 2023

dev was not up-to-date with main. I updated it, but now you need to resolve a few conflicts.

@hagenw
Copy link
Member

hagenw commented May 9, 2023

In audeering/audbackend#76 (comment) I proposed a migration plan that would allow us to also re-enable the emodb related tests here without affecting the tests of the main branch.

@frankenjoe
Copy link
Collaborator Author

Unfortunately, I was not able to properly rebase the branch. First it didn't let me push (due to some server errors of Github) and now it shows unexpected changes. I will close this PR and instead move the discussion to #306

@frankenjoe frankenjoe closed this May 9, 2023
@hagenw hagenw deleted the new-backend branch May 3, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants