Create sDDF LWIP Library #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wom-bat
requested changes
Sep 9, 2024
JE-Archer
force-pushed
the
lwip_sddf_library
branch
2 times, most recently
from
0f893d2 to
767a210
Compare
JE-Archer
force-pushed
the
lwip_sddf_library
branch
6 times, most recently
from
166da18 to
291d391
Compare
JE-Archer
force-pushed
the
lwip_sddf_library
branch
3 times, most recently
from
18359bf to
0ceec77
Compare
JE-Archer
force-pushed
the
lwip_sddf_library
branch
2 times, most recently
from
c0afc7b to
ecdec83
Compare
JE-Archer
force-pushed
the
lwip_sddf_library
branch
3 times, most recently
from
e6cfb58 to
95ea4fb
Compare
JE-Archer
force-pushed
the
lwip_sddf_library
branch
from
95ea4fb to
535ad16
Compare
Ivan-Velickovic
force-pushed
the
sdfgen_0.16.0
branch
from
d977b80 to
5d2adf1
Compare
JE-Archer
force-pushed
the
lwip_sddf_library
branch
from
535ad16 to
6aacfa6
Compare
Co-authored-by: Courtney Darville <[email protected]> Signed-off-by: James Archer <[email protected]>
Co-authored-by: Courtney Darville <[email protected]> Co-authored-by: James Archer <[email protected]> Signed-off-by: James Archer <[email protected]>
Co-authored-by: Courtney Darville <[email protected]> Co-authored-by: James Archer <[email protected]> Signed-off-by: James Archer <[email protected]>
JE-Archer
force-pushed
the
lwip_sddf_library
branch
from
6aacfa6 to
962766d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR create a reusable interfacing library for sDDF networking and LWIP. The generic components of
lwip.chave been moved into a separate library filelib_sddf_lwip.cand may now be used by any microkit component that wishes to use sDDF networking and LWIP. These functionalities are largely:Currently the library (of one c file) is built as a static archive using a makefile snippet. This implicitly relies on some standard library functions such as
memcpybeing available. Although the current makefile snippet works fine for the echo server example, there are two issues with it going forward:lwipopts.hconfig file, as well as theSDDF_LWIP_NUM_BUFFSconstant which determines how much memory needs to be allocated for pbufs (currently passed in as a build time parameter).This library has also been integrated in LionsOS for both NFS and micropython components, and works successfully. Although since the above two issues have not yet been resolved, the library object file is made in each of the makefiles of micropython and NFS, rather than in the main Kitty and Webserver makefiles themselves.