Refactor @tomic/svelte to Svelte 5 and update sveltekit-site template #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polleps
force-pushed
the
svelte-5-refactor-#700
branch
from
1a0865f to
524d990
Compare
joepio
reviewed
Nov 6, 2024
browser/lib/src/ontologies/core.ts
Outdated
| @@ -112,7 +146,7 @@ declare module '../index.js' { | |||
| [core.properties.write]: string[]; | |||
| [core.properties.publicKey]: string; | |||
| [core.properties.instances]: string[]; | |||
| [core.properties.properties]: string[]; | |||
| [core.properties.properties]: undefined; | |||
joepio
reviewed
Nov 6, 2024
| /** | ||
| * Starts fetching a resource and adds it to the store. | ||
| * An empty resource will be returned immediately that updates when the resource is fetched. | ||
| * This way you can start rendering UI that |
joepio
reviewed
Nov 6, 2024
joepio
reviewed
Nov 6, 2024
| This library is still at an early stage and the API is subject to change. | ||
| An AtomicServer client for [Svelte](https://svelte.dev/). | ||
| Makes fetching AtomicData easy. | ||
| Fetched resources are chached and reactive, they will update when the data changes, even when the resource was changed by someone else. | ||
|
|
There was a problem hiding this comment.
mention older svelte version without runes and max supported version of @tomic/svelte
joepio
reviewed
Nov 6, 2024
docs/src/svelte.md
Outdated
| const store = getStoreFromContext(); | ||
| store.newResource({ | ||
| isA: [dataBrowser.classes.Folder] | ||
| parant: 'some_other_subject', |
joepio
reviewed
Nov 7, 2024
docs/src/svelte.md
Outdated
|
|
||
| [See open source template: `atomic-sveltekit-demo` (outdated).](https://github.com/atomicdata-dev/atomic-sveltekit-demo) | ||
|
|
||
| > **Note:** @tomic/svelte requires Svelte 5 or later. Svelte 4 is not supported. |
There was a problem hiding this comment.
Do mention that older versions do work.
Polleps
force-pushed
the
svelte-5-refactor-#700
branch
from
e089f98 to
edce8ba
Compare
…e not in the resources classdefs #700
Polleps
force-pushed
the
svelte-5-refactor-#700
branch
from
edce8ba to
0880269
Compare
joepio
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
closes #700
Checklist