Fix indicator jumping when scrolling table with keyboard

atomicdata-dev · Jul 17, 2024 · d8a839f · d8a839f
1 parent 0b516b2
commit d8a839f
Showing 1 changed file with 18 additions and 9 deletions.
diff --git a/browser/data-browser/src/components/TableEditor/ActiveCellIndicator.tsx b/browser/data-browser/src/components/TableEditor/ActiveCellIndicator.tsx
@@ -11,10 +11,16 @@ import {
 import { scrollIntoView } from './helpers/scrollIntoView';
 import { CursorMode, useTableEditorContext } from './TableEditorContext';
 
+type OnScrollCallbackOptions = {
+  scrollUpdateWasRequested: boolean;
+};
+
 export interface ActiveCellIndicatorProps {
   sizeStr: string;
   scrollerRef: React.RefObject<HTMLDivElement>;
-  setOnScroll: (onScroll: () => void) => void;
+  setOnScroll: (
+    onScroll: ({ scrollUpdateWasRequested }: OnScrollCallbackOptions) => void,
+  ) => void;
 }
 
 const cursorGoesOffscreen = (parentRect: DOMRect, childRect: DOMRect) => {
@@ -128,14 +134,17 @@ export function ActiveCellIndicator({
   );
 
   useEffect(() => {
-    setOnScroll(() => (_, __, requested: boolean) => {
-      if (requested) {
-        return;
-      }
-
-      setScrolling(true);
-      updatePosition(false);
-    });
+    setOnScroll(
+      () =>
+        ({ scrollUpdateWasRequested }: OnScrollCallbackOptions) => {
+          if (scrollUpdateWasRequested) {
+            return;
+          }
+
+          setScrolling(true);
+          updatePosition(false);
+        },
+    );
   }, [updatePosition]);
 
   useEffect(() => {