Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use docblocks for types #43

Merged
merged 1 commit into from
Jan 24, 2021
Merged

docs: use docblocks for types #43

merged 1 commit into from
Jan 24, 2021

Conversation

bennypowers
Copy link
Member

@aminya
Copy link
Member

aminya commented Jan 24, 2021

I am fixing the deps issue in #44

@aminya aminya force-pushed the docs/inline-docblock branch from 275f39c to 61c9454 Compare January 24, 2021 13:03
@aminya aminya added the documentation Improvements or additions to documentation label Jan 24, 2021
@aminya
Copy link
Member

aminya commented Jan 24, 2021 •
edited
Loading

@bennypowers Should I release a new npm version for this?

@aminya aminya merged commit 77fd058 into atom-community:master Jan 24, 2021
@bennypowers
Copy link
Member Author

@bennypowers Should I release a new npm version for this?

for now I'm using patch-package in the docs branch to get these comments in to the wip docs pages, so a release is not crucial.

@aminya
Copy link
Member

aminya commented Jan 24, 2021

OK. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminya aminya aminya approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennypowers @aminya