Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and improve trainee dashboard #438

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

aimedivin
Copy link
Member

@aimedivin aimedivin commented Nov 20, 2024

PR Description

This PR focuses on refactoring and improving the queries used on trainee dashboard

Description of tasks that were expected to be completed

  • added createdAt field to get rating for trainee in definition for the query
  • added logic to get average attendance calculation for a trainee
  • Ensured my changes work well doesn't affect other existing

Functionality

How does this works, add some information that maybe needed in testing

How has this been tested?

  git clone https://github.com/atlp-rwanda/atlp-pulse-bn.git
  cd atlp-pulse-bn
  git checkout fix-trainee-dashboard
  npm i
  • Ensure that you have set your .env file using .env.example.
    • For the app
    npm run dev
    
    The functionality was tested using Apollo Sandbox

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 76 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@6fd2a27). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/attendance.resolvers.ts 3.38% 57 Missing ⚠️
src/resolvers/ratingsResolvers.ts 11.76% 15 Missing ⚠️
src/resolvers/userResolver.ts 0.00% 3 Missing ⚠️
src/resolvers/2fa.resolvers.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #438   +/-   ##
==========================================
  Coverage           ?   16.60%           
==========================================
  Files              ?      101           
  Lines              ?     3891           
  Branches           ?     1097           
==========================================
  Hits               ?      646           
  Misses             ?     3234           
  Partials           ?       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@aimedivin aimedivin changed the title fix: fixes and improves trainee dashboard Refactor and improve trainee dashboard Nov 20, 2024
@aimedivin aimedivin requested a review from Ke-bean November 20, 2024 20:06
@aimedivin aimedivin force-pushed the fix-trainee-dashboard branch from 1fc7d31 to c0c09e3 Compare November 21, 2024 06:17
@ceelogre ceelogre temporarily deployed to fix-trainee-dashboard - devpulse-backend PR #438 November 21, 2024 06:17 — with Render Destroyed
@Salim-54 Salim-54 merged commit 5f5a2d1 into develop Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants