fixing login with 2fa #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #437 +/- ##
==========================================
Coverage ? 31.23%
==========================================
Files ? 87
Lines ? 4213
Branches ? 1233
==========================================
Hits ? 1316
Misses ? 2866
Partials ? 31 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
janet-barbie
requested review from
Bananayosostene,
JacquelineTuyisenge and
Tuyisenge2
janet-barbie
force-pushed
the
fix-2fa-#303
branch
from
736e2d4 to
8392ff9
Compare
janet-barbie
added
bug
janet-barbie
force-pushed
the
fix-2fa-#303
branch
from
8392ff9 to
6274095
Compare
JacquelineTuyisenge
approved these changes
Nov 21, 2024
janet-barbie
force-pushed
the
fix-2fa-#303
branch
from
6274095 to
736c1cb
Compare
ceelogre
temporarily deployed
to
fix-2fa-#303 - devpulse-backend PR #437
Render
Destroyed
Tuyisenge2
approved these changes
Nov 21, 2024
aimedivin
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This pull request fixes issue raised on login with two factor authentication
Description of tasks that were expected to be completed
I changed the secret value to match the value of secret key in user helper. also i removed two way verification token from response, and a user is not prompted to enter two way verification token while logging in with otp
Functionality
Login and enable two factor authentication you will be sent a notification email. try to Login an email with an otp code will be sent in your response .then loginWithTwoFactorAuthentication provide an otp code and your email
How has this been tested?
Tested using graphql appolo server