Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-query-paginations #238

Closed
wants to merge 2 commits into from
Closed

Conversation

iyaremye-faustin
Copy link

PR Description

Query Paginations.

Description of tasks that were expected to be completed

Adding paginations to queries that expect to return larage amount of data.

Functionality

When requesting queries , page and limit are submitted to have the response paginated

How has this been tested?

Start with getUsers query and page and limit for the result to be paginated

Copy link

railway-app bot commented Jul 29, 2024

This PR was not deployed automatically as @iyaremye-faustin does not have access to the Railway project.

In order to get automatic PR deploys, please add @iyaremye-faustin to the project inside the project settings page.

@ceelogre ceelogre closed this Aug 1, 2024
@ceelogre ceelogre reopened this Aug 1, 2024
Copy link

render bot commented Aug 1, 2024

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 40 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@44b53d8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/session.resolver.ts 5.88% 32 Missing ⚠️
src/resolvers/coordinatorResolvers.ts 0.00% 6 Missing ⚠️
src/utils/logGraphQLRequests.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #238   +/-   ##
==========================================
  Coverage           ?   17.08%           
==========================================
  Files              ?       61           
  Lines              ?     2183           
  Branches           ?      646           
==========================================
  Hits               ?      373           
  Misses             ?     1805           
  Partials           ?        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ceelogre ceelogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've triggered a deployment for you. Please raise the frontend PR so we can test it.

@ceelogre ceelogre marked this pull request as draft August 21, 2024 15:13
@ceelogre
Copy link
Contributor

To be re-implemented.

@ceelogre ceelogre closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants