Enforce security check on GHES app #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamaksheeAtl
approved these changes
Jan 2, 2024
…ity-check-on-uuid
gxueatlassian
merged commit e37091f
into
ARC-2777-Reactify-GHE-backfill-pg
4 of 5 checks passed
gxueatlassian
deleted the
ARC-2777-Reactify-GHE-backfill-pg--security-check-on-uuid
branch
kamaksheeAtl
added a commit
that referenced
this pull request
Jan 3, 2024
* chore: make spa wrapper width variable * chore: rectify colum names * chore: work to delete ghe server * chore: update test cases * chore: add test cases * fix: build error * chore: add test cases * chore: add test cases * chore: add config option for GHR server app * chore: refactor code * chore: pr review comments * chore: update code as per PR comments * chore: update code as per PR comments * Enforce security check on GHES app (#2624) --------- Co-authored-by: Gary Xue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Use existing GitHubAppMiddleware to enforce the security check
Why
We are starting to expose the GHES function to rest-router, we need some security check on it.