add dlq-service during BB pipeline #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxueatlassian
commented
Dec 14, 2023
There was a problem hiding this comment.
No point of having this file now.
gxueatlassian
commented
Dec 14, 2023
| @@ -18,7 +18,7 @@ COPY . /app | |||
| WORKDIR /app | |||
|
|
|||
| # Installing packages | |||
| RUN rm .yarnrc | |||
| RUN yarn add @atlassian/sqs-queue-dlq-service | |||
There was a problem hiding this comment.
The only drawback is we are not frozen this dep to a specific version, but I guess that's okay, since it is only used as our queue replay api, if failed, won't affect customer (in a disaster way)
bgvozdev
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
add dlq-service during BB pipeline
Why
Added feature flags
Affected issues
How has this been tested?
https://bitbucket.org/atlassian/github-for-jira-deployment/pipelines/results/8402
Whats Next?