Arc 2745 fix exp time #2613
Closed
Arc 2745 fix exp time #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgvozdev
approved these changes
Dec 13, 2023
yvonnevictoria
approved these changes
Dec 13, 2023
krazziekay
reviewed
Dec 13, 2023
| @@ -36,7 +37,7 @@ export const GHESVerifyGetApps = async (req: Request, res: Response): Promise<vo | |||
| const output = await runCurl({ | |||
| fullUrl: `${gitHubAppClient.restApiUrl}/app`, | |||
| method: "GET", | |||
| authorization: `Bearer ${AppTokenHolder.createAppJwt(await app.getDecryptedPrivateKey(installation.jiraHost), String(app.appId)).token}` | |||
| authorization: `Bearer ${AppTokenHolder.createAppJwt(await app.getDecryptedPrivateKey(installation.jiraHost), String(app.appId), FIVE_MINUTES_IN_MILLI_SEC).token}` | |||
There was a problem hiding this comment.
Why are we not feature flagging this too?
There was a problem hiding this comment.
I realize that this is for the API endpoints that we use, but we can't test the exp time set in FF from this endpoint , can we?
So if the customer is still facing this issue, we can't test the value in the FF through this endpoint cause its set to 5 minutes.
|
I don't like my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add ff to reduce the app token exp time
Why
TEN MINUTES is the max allowed, prone to error
Added feature flags
app-token-exp-in-milli-sec
Affected issues
ARC-2745
How has this been tested?
Unit test
Whats Next?