Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial docs/README.md to mime component #497

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

Blacksmoke16
Copy link
Member

@Blacksmoke16 Blacksmoke16 commented Jan 2, 2025

Context

Add initial docs/README.md to mime component. Not having this was preventing the docs CI job from passing. Updated the component template repo to include this so won't happen again in the future.

Changelog

  • Add initial docs/README.md to mime component

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@Blacksmoke16 Blacksmoke16 added kind:bug An existing feature isn't working as expected kind:documentation component:mime labels Jan 2, 2025
@Blacksmoke16 Blacksmoke16 enabled auto-merge (squash) January 2, 2025 02:52
@Blacksmoke16 Blacksmoke16 merged commit c8c1b86 into master Jan 2, 2025
12 checks passed
@Blacksmoke16 Blacksmoke16 deleted the mime-docs branch January 2, 2025 02:56
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Flag Coverage Δ
compiled 8.12% <ø> (ø)
unit 92.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 98.18% <ø> (ø)
console 92.74% <ø> (ø)
dependency_injection 64.28% <ø> (ø)
dotenv 96.80% <ø> (ø)
event_dispatcher 82.75% <ø> (ø)
framework 94.10% <ø> (ø)
image_size 95.03% <ø> (ø)
mercure 93.37% <ø> (ø)
negotiation 97.69% <ø> (ø)
routing 92.96% <ø> (ø)
serializer 87.23% <ø> (ø)
spec 93.54% <ø> (ø)
validator 92.39% <ø> (ø)

📢 Thoughts on this report? Let us know!

PallasAthenaie pushed a commit to athena-framework/mime that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:mime kind:bug An existing feature isn't working as expected kind:documentation
Development

Successfully merging this pull request may close these issues.

1 participant