Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and make require_tld: true the default for AVD::Constraints::URL constraint #492

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Blacksmoke16
Copy link
Member

@Blacksmoke16 Blacksmoke16 commented Dec 16, 2024

Context

Add and make require_tld: true the default for URL constraint. This'll technically make the constraint more strict by default, but also more useful for the most common use cases. I.e. ensuring https://example.com is valid but https://example is not.

Resolve #439

Changelog

  • Breaking: Add and make require_tld: true the default for AVD::Constraints::URL constraint

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
compiled 8.11% <11.11%> (+<0.01%) ⬆️
unit 92.78% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 98.18% <ø> (ø)
console 92.74% <ø> (+0.15%) ⬆️
dependency_injection 64.28% <ø> (ø)
dotenv 96.80% <ø> (ø)
event_dispatcher 82.75% <ø> (ø)
framework 94.10% <ø> (ø)
image_size 95.03% <ø> (ø)
mercure 93.37% <ø> (ø)
negotiation 97.69% <ø> (ø)
routing 92.96% <ø> (ø)
serializer 87.23% <ø> (ø)
spec 93.54% <ø> (ø)
validator 92.39% <100.00%> (+0.02%) ⬆️

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 merged commit 84bb6e2 into master Dec 16, 2024
14 checks passed
@Blacksmoke16 Blacksmoke16 deleted the require-tld branch December 16, 2024 01:44
PallasAthenaie pushed a commit to athena-framework/validator that referenced this pull request Dec 16, 2024
@Blacksmoke16 Blacksmoke16 added kind:enhancement New functionality to an existing feature and removed kind:feature Brand new functionality labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking component:validator kind:enhancement New functionality to an existing feature
Development

Successfully merging this pull request may close these issues.

Add a require_tld option to URL constraint
1 participant