Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only return exit code 1, if that's what the spec run did #487

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

Blacksmoke16
Copy link
Member

Context

It seems that kcov can return 127 sometimes, likely due to a bug. This was causing an issue making the CI job fail due to non-zero exit code. This PR makes it a bit more strict by only failing the script if it failed with exit code 1.

Changelog

  • Fix unexpected non zero exit codes in scripts/test.sh

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@Blacksmoke16 Blacksmoke16 added kind:bug An existing feature isn't working as expected kind:infrastructure labels Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
compiled 8.14% <ø> (-0.02%) ⬇️
unit 92.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 98.18% <ø> (ø)
console 92.61% <ø> (ø)
dependency_injection 64.28% <ø> (ø)
dotenv 96.80% <ø> (ø)
event_dispatcher 82.75% <ø> (ø)
framework 94.27% <ø> (ø)
image_size 95.03% <ø> (ø)
mercure 93.37% <ø> (ø)
negotiation 97.69% <ø> (ø)
routing 92.96% <ø> (ø)
serializer 87.23% <ø> (ø)
spec 93.54% <ø> (ø)
validator 92.37% <ø> (ø)

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 merged commit b50813e into master Dec 15, 2024
14 checks passed
@Blacksmoke16 Blacksmoke16 deleted the fix-test-script branch December 15, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug An existing feature isn't working as expected kind:infrastructure
Development

Successfully merging this pull request may close these issues.

1 participant