Only return exit code 1, if that's what the spec run did #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It seems that
kcov
can return127
sometimes, likely due to a bug. This was causing an issue making the CI job fail due to non-zero exit code. This PR makes it a bit more strict by only failing the script if it failed with exit code 1.Changelog
scripts/test.sh
Before merging, remember to add the
athena-framework/athena
prefix to the PR number in the PR title