Enable Lint/UselessAssign ameba rule again but excluding type declarations
#446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blacksmoke16
added
component:ecosystem
Blacksmoke16
commented
Aug 20, 2024
Comment on lines
+223
to
224
| # ameba:disable Lint/UselessAssign | ||
| unless env = ENV[env_key]? |
There was a problem hiding this comment.
Reported this as crystal-ameba/ameba#468.
PallasAthenaie
pushed a commit
to athena-framework/dependency-injection
that referenced
this pull request
Aug 20, 2024
PallasAthenaie
pushed a commit
to athena-framework/dotenv
that referenced
this pull request
Aug 20, 2024
PallasAthenaie
pushed a commit
to athena-framework/framework
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Follow up to #344 to leverage the new
ExcludeTypeDeclarationsconfiguration option added via crystal-ameba/ameba#430 instead of totally disabling the rule. Allows retaining actual useless assignments without also flagging all the bundle property macro calls.Changelog
Lint/UselessAssignameba rule again but excluding type declarationsBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title