Fix handling of TINYINT(1) UNSIGNED when tinyInt1isBit is set
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchrys
force-pushed
the
fix-unsigned-tinyint
branch
2 times, most recently
from
167617d to
4e4d824
Compare
jchrys
force-pushed
the
fix-unsigned-tinyint
branch
2 times, most recently
from
742f717 to
dba54af
Compare
Motivation: When the `tinyInt1isBit` flag is set, attempting to convert `TINYINT(1) UNSIGNED` to a boolean results in immediate rejection. Modifications: Prevent conversion of `TINYINT(1) UNSIGNED` to boolean when `tinyInt1isBit` is enabled. Result: `TINYINT(1) UNSIGNED` is handled correctly without unnecessary conversion attempts.
jchrys
force-pushed
the
fix-unsigned-tinyint
branch
from
dba54af to
24ec2d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When the
tinyInt1isBitflag is set, attempting to convertTINYINT(1) UNSIGNEDto a boolean results in immediate rejection.Modifications:
Prevent conversion of
TINYINT(1) UNSIGNEDto boolean whentinyInt1isBitis enabled.Result:
TINYINT(1) UNSIGNEDis handled correctly without unnecessary conversion attempts.