Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blog): add 2024 conference summary #3601

Merged
merged 15 commits into from
Jan 29, 2025
Merged

Conversation

thulieblack
Copy link
Member

@thulieblack thulieblack commented Jan 22, 2025

Summary for the 2024 AsyncAPI Conference.

Summary by CodeRabbit

  • New Features
    • Added a comprehensive report for the AsyncAPI Conference 2024, detailing conference highlights, challenges, attendance, sponsors, and future plans.
    • Included information about in-person and online conference events, speaker acknowledgments, and a preview of the 2025 conference.

Copy link
Contributor

coderabbitai bot commented Jan 22, 2025

Walkthrough

The pull request introduces a new markdown file titled "AsyncAPI Conference 2024 Report," documenting the events and outcomes of the AsyncAPI Conference held in 2024. It includes metadata, details about the planning process, challenges faced, attendance figures, sponsorship acknowledgments, and future event plans, including a call for speakers for the 2025 conference.

Changes

File Change Summary
markdown/blog/conference-2024-summary.md New file created documenting the AsyncAPI Conference 2024, covering planning, challenges, attendance, sponsors, acknowledgments, and future events.

Possibly related PRs

Suggested labels

ready-to-merge

Suggested reviewers

  • akshatnema
  • magicmatatjahu
  • anshgoyalevil
  • Mayaleeeee
  • sambhavgupta0705
  • BhaswatiRoy
  • derberg
  • quetzalliwrites

Poem

🐰 Conference rabbits hop with glee,
AsyncAPI's story, now we see!
From Paris to screens both near and far,
Community shines like a bright star ✨
2024's tale, now written with care,
Connecting developers everywhere! 🌍


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a877e23
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/679129dc3b1efe0008536557
😎 Deploy Preview https://deploy-preview-3601--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 374f96c
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6799e4d2305ea3000895d7d2
😎 Deploy Preview https://deploy-preview-3601--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Jan 27, 2025

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 34
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3601--asyncapi-website.netlify.app/

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ea1ef0f) to head (374f96c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3601   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          732       732           
=========================================
  Hits           732       732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
markdown/blog/conference-2024-summary.md (3)

53-53: Consider using responsive image sizing.

Instead of fixed pixel widths, consider using relative units or CSS classes for responsive image sizing. This will ensure better display across different screen sizes.

Also applies to: 60-60, 65-65


117-120: Fix list indentation.

Remove the extra space before the list items to follow markdown formatting guidelines.

-  - Singapore on **the 15th - 16th of April**.
-  - Munich on **the 2nd - 3rd of July**.
-  - London on **the 22nd - 24th of September**.
-  - Paris on **the 9th -11th of December**.
+ - Singapore on **the 15th - 16th of April**.
+ - Munich on **the 2nd - 3rd of July**.
+ - London on **the 22nd - 24th of September**.
+ - Paris on **the 9th -11th of December**.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

117-117: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


118-118: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


119-119: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


120-120: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


133-133: Fix typo in link text.

There's a formatting issue in the link text: T[he should be [The.

-T[he call for speakers for AsyncAPI Conf Singapore is now open]
+[The call for speakers for AsyncAPI Conf Singapore is now open]
🧰 Tools
🪛 LanguageTool

[grammar] ~133-~133: The pronoun ‘he’ is usually used with a third-person or a past tense verb.
Context: ... ## Call for Speakers, Singapore T[he call for speakers for AsyncAPI Conf Singapor...

(HE_VERB_AGR)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4b12e0 and 44dc597.

📒 Files selected for processing (1)
  • markdown/blog/conference-2024-summary.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
markdown/blog/conference-2024-summary.md

[duplication] ~75-~75: Possible typo: you repeated a word.
Context: ...aterials and set up the booth tables. <Profiles profiles={[ { name: 'Lukasz Gornicki', ...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~111-~111: Loose punctuation mark.
Context: ... 'https://github.com/ashmit-coder' } ]} /> ## Where, Too, In 2025? For Async...

(UNLIKELY_OPENING_PUNCTUATION)


[grammar] ~133-~133: The pronoun ‘he’ is usually used with a third-person or a past tense verb.
Context: ... ## Call for Speakers, Singapore T[he call for speakers for AsyncAPI Conf Singapor...

(HE_VERB_AGR)

🪛 markdownlint-cli2 (0.17.2)
markdown/blog/conference-2024-summary.md

45-45: Spaces inside emphasis markers
null

(MD037, no-space-in-emphasis)


117-117: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


118-118: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


119-119: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


120-120: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


126-126: No empty links
null

(MD042, no-empty-links)

⏰ Context from checks skipped due to timeout of 180000ms (3)
  • GitHub Check: Redirect rules - asyncapi-website
  • GitHub Check: Header rules - asyncapi-website
  • GitHub Check: Pages changed - asyncapi-website
🔇 Additional comments (2)
markdown/blog/conference-2024-summary.md (2)

3-3: Verify if the future publication date is intentional.

The blog post is dated January 28, 2025, which is in the future. Consider updating it to the current date unless this is intentionally scheduled for future publication.


45-45: Fix markdown formatting and verify attendance numbers.

  1. Remove spaces inside the bold markers: change ** 380** to **380** and **446 ** to **446**.
  2. Based on the previous comment from thulieblack, these numbers need verification.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

45-45: Spaces inside emphasis markers
null

(MD037, no-space-in-emphasis)

markdown/blog/conference-2024-summary.md Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
markdown/blog/conference-2024-summary.md (1)

126-126: ⚠️ Potential issue

Add the missing sponsorship prospectus link.

The link to the conference sponsorship prospectus is empty.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

126-126: No empty links
null

(MD042, no-empty-links)

🧹 Nitpick comments (1)
markdown/blog/conference-2024-summary.md (1)

7-7: Optimize images to improve performance.

The Lighthouse report shows a low performance score (35/100). Consider optimizing all images in the post:

  1. Use appropriate image dimensions
  2. Compress images
  3. Consider using next-gen formats like WebP
  4. Implement lazy loading for images below the fold

Would you like me to help generate an image optimization script?

Also applies to: 27-27, 53-53, 60-60, 65-65

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44dc597 and dd2327f.

📒 Files selected for processing (1)
  • markdown/blog/conference-2024-summary.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
markdown/blog/conference-2024-summary.md

[duplication] ~75-~75: Possible typo: you repeated a word.
Context: ...aterials and set up the booth tables. <Profiles profiles={[ { name: 'Lukasz Gornicki', ...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~111-~111: Loose punctuation mark.
Context: ... 'https://github.com/ashmit-coder' } ]} /> ## Where, Too, In 2025? For Async...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 markdownlint-cli2 (0.17.2)
markdown/blog/conference-2024-summary.md

45-45: Spaces inside emphasis markers
null

(MD037, no-space-in-emphasis)


126-126: No empty links
null

(MD042, no-empty-links)

⏰ Context from checks skipped due to timeout of 180000ms (1)
  • GitHub Check: Test NodeJS PR - macos-13
🔇 Additional comments (4)
markdown/blog/conference-2024-summary.md (4)

1-15: LGTM! Frontmatter is well-structured.

All required metadata fields are present and properly formatted.


45-45: Fix formatting and verify attendance numbers.

  1. Remove the space in "**446 **views"
  2. The attendance numbers were questioned in a previous review. Please verify these statistics.
-Over **380** people attended our in-person conference, and we had more than **450** views during our AsyncAPI Online Conference livestream. Additionally, the recorded sessions received over **446 **views after the conference.
+Over **380** people attended our in-person conference, and we had more than **450** views during our AsyncAPI Online Conference livestream. Additionally, the recorded sessions received over **446** views after the conference.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

45-45: Spaces inside emphasis markers
null

(MD037, no-space-in-emphasis)


53-53: Update the APIdays logo path to reference 2024.

The image path still references the 2023 directory.

-<img src='/img/posts/2023-summary/apidays-logo-2023.png' alt='apidays' width='500px' />
+<img src='/img/posts/2024-conference/apidays-logo.png' alt='apidays' width='500px' />

26-28: Update the image path to reference 2024.

The image path still references the 2023 directory instead of 2024.

-  src="/img/posts/2023-summary/locations.webp"
+  src="/img/posts/2024-conference/locations.webp"

markdown/blog/conference-2024-summary.md Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (1)
markdown/blog/conference-2024-summary.md (1)

126-126: ⚠️ Potential issue

Add missing link for the sponsorship prospectus.

The link to download the conference sponsorship prospectus is empty.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

126-126: No empty links
null

(MD042, no-empty-links)

🧹 Nitpick comments (3)
markdown/blog/conference-2024-summary.md (3)

45-45: Fix the formatting inconsistency in numbers.

The formatting of numbers is inconsistent. The spacing in "446 **views" creates incorrect emphasis.

-Over **580** people attended our in-person conference, and we had more than **450** views during our AsyncAPI Online Conference livestream. Additionally, the recorded sessions received over **446 **views after the conference.
+Over **580** people attended our in-person conference, and we had more than **450** views during our AsyncAPI Online Conference livestream. Additionally, the recorded sessions received over **446** views after the conference.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

45-45: Spaces inside emphasis markers
null

(MD037, no-space-in-emphasis)


115-115: Fix typo in heading.

The heading contains a grammatical error.

-## Where, Too, In 2025?
+## Where to in 2025?

21-21: Standardize heading capitalization.

The capitalization in headings is inconsistent. Consider standardizing to either title case or sentence case across all headings.

Current headings:

  • Planning Process
  • Challenges
  • Attendance
  • Conference Sponsors
  • Special Shout Out
  • Where, Too, In 2025?
  • Call for Speakers, Singapore

Also applies to: 37-37, 42-42, 49-49, 68-68, 115-115, 131-131

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd2327f and 261a8e3.

📒 Files selected for processing (1)
  • markdown/blog/conference-2024-summary.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
markdown/blog/conference-2024-summary.md

[duplication] ~75-~75: Possible typo: you repeated a word.
Context: ...aterials and set up the booth tables. <Profiles profiles={[ { name: 'Lukasz Gornicki', ...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~111-~111: Loose punctuation mark.
Context: ... 'https://github.com/ashmit-coder' } ]} /> ## Where, Too, In 2025? For Async...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 markdownlint-cli2 (0.17.2)
markdown/blog/conference-2024-summary.md

45-45: Spaces inside emphasis markers
null

(MD037, no-space-in-emphasis)


126-126: No empty links
null

(MD042, no-empty-links)

🔇 Additional comments (2)
markdown/blog/conference-2024-summary.md (2)

3-3: Verify if the future publication date is intentional.

The blog post is dated January 28, 2025, which is in the future. Please confirm if this scheduling is intentional.


45-45: Verify the attendance numbers.

Based on the previous discussion, these numbers were estimated. Please confirm the final attendance figures for accuracy.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

45-45: Spaces inside emphasis markers
null

(MD037, no-space-in-emphasis)

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just link to prospectus is missing

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
markdown/blog/conference-2024-summary.md (3)

20-20: Remove unnecessary empty line.

There's an extra empty line that can be removed to maintain consistent spacing.


53-53: Consider standardizing sponsor logo dimensions.

All sponsor logos are set to width='500px' but might benefit from consistent height constraints to maintain uniform visual presentation.

Consider adding height constraints or using CSS classes for consistent sponsor logo sizing:

-<img src='/img/posts/2023-summary/apidays-logo-2023.png' alt='apidays' width='500px' />
+<img src='/img/posts/2023-summary/apidays-logo-2023.png' alt='apidays' width='500px' className="sponsor-logo" />

Add corresponding CSS:

.sponsor-logo {
  width: 500px;
  height: 200px; /* adjust as needed */
  object-fit: contain;
}

Also applies to: 60-60, 65-65


115-115: Consider revising the section heading for clarity.

The current heading "Where To In 2025?" could be more grammatically correct.

Consider these alternatives:

  • "What's Coming in 2025?"
  • "Where Are We Heading in 2025?"
  • "AsyncAPI Conference Locations for 2025"
🧰 Tools
🪛 LanguageTool

[grammar] ~115-~115: This question appears to miss a verb.
Context: ...ithub.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI Conference 2025, we are ex...

(QUESTION_WITHOUT_VERB)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 261a8e3 and 7f89719.

📒 Files selected for processing (1)
  • markdown/blog/conference-2024-summary.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
markdown/blog/conference-2024-summary.md

[duplication] ~75-~75: Possible typo: you repeated a word.
Context: ...aterials and set up the booth tables. <Profiles profiles={[ { name: 'Lukasz Gornicki', ...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~111-~111: Loose punctuation mark.
Context: ... 'https://github.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI...

(UNLIKELY_OPENING_PUNCTUATION)


[grammar] ~115-~115: This question appears to miss a verb.
Context: ...ithub.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI Conference 2025, we are ex...

(QUESTION_WITHOUT_VERB)

🪛 markdownlint-cli2 (0.17.2)
markdown/blog/conference-2024-summary.md

126-126: No empty links
null

(MD042, no-empty-links)

🔇 Additional comments (5)
markdown/blog/conference-2024-summary.md (5)

3-3: Verify if the future publication date is intentional.

The blog post is dated January 28, 2025. Please confirm if this future date is intentional or if it should be adjusted to a current date.


21-36: LGTM! Well-structured section with proper links and visual content.

The planning process section effectively communicates the conference structure and provides easy access to detailed summaries of each event.


45-45: LGTM! Attendance numbers have been verified.

The attendance numbers have been confirmed by the team in previous reviews.


68-113: LGTM! Well-structured acknowledgments section.

The special shout-out section effectively recognizes contributors using the Profiles component.

🧰 Tools
🪛 LanguageTool

[duplication] ~75-~75: Possible typo: you repeated a word.
Context: ...aterials and set up the booth tables. <Profiles profiles={[ { name: 'Lukasz Gornicki', ...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~111-~111: Loose punctuation mark.
Context: ... 'https://github.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI...

(UNLIKELY_OPENING_PUNCTUATION)


126-126: Add missing link for the sponsorship prospectus.

The link to download the conference sponsorship prospectus is empty. Please add the correct URL.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

126-126: No empty links
null

(MD042, no-empty-links)

@thulieblack
Copy link
Member Author

Yes, the prospectus is missing still busy with it; I'll add the link once it's ready

@thulieblack
Copy link
Member Author

@derberg please approve and merge 😁😁

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
markdown/blog/conference-2024-summary.md (2)

16-16: Improve quote formatting.

Consider using markdown blockquote syntax for better visual presentation.

-As the saying goes, `"The second time is a charm."` AsyncAPI Conf on Tour returned in 2024
+As the saying goes, > "The second time is a charm." AsyncAPI Conf on Tour returned in 2024

115-115: Improve heading grammar.

The heading "Where To In 2025?" could be more grammatically correct.

-## Where To In 2025?
+## Where Are We Heading In 2025?
🧰 Tools
🪛 LanguageTool

[grammar] ~115-~115: This question appears to miss a verb.
Context: ...ithub.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI Conference 2025, we are ex...

(QUESTION_WITHOUT_VERB)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f89719 and e3db989.

📒 Files selected for processing (1)
  • markdown/blog/conference-2024-summary.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
markdown/blog/conference-2024-summary.md

[duplication] ~75-~75: Possible typo: you repeated a word.
Context: ...aterials and set up the booth tables. <Profiles profiles={[ { name: 'Lukasz Gornicki', ...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~111-~111: Loose punctuation mark.
Context: ... 'https://github.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI...

(UNLIKELY_OPENING_PUNCTUATION)


[grammar] ~115-~115: This question appears to miss a verb.
Context: ...ithub.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI Conference 2025, we are ex...

(QUESTION_WITHOUT_VERB)

🔇 Additional comments (4)
markdown/blog/conference-2024-summary.md (4)

3-3: Verify the publication date.

The blog post date is set to January 28, 2025, which is in the future. Consider setting it to the current date or a past date when the conference summary was actually written.


45-45: LGTM! Attendance numbers have been verified.

The attendance numbers have been confirmed and updated as per the previous review discussion.


49-67: LGTM! Sponsor section is well-structured.

The sponsor logos and acknowledgments are properly formatted with appropriate alt text and width attributes.


75-112: LGTM! Contributors section is well-structured.

The Profiles component correctly lists all contributors with their avatars and links.

🧰 Tools
🪛 LanguageTool

[duplication] ~75-~75: Possible typo: you repeated a word.
Context: ...aterials and set up the booth tables. <Profiles profiles={[ { name: 'Lukasz Gornicki', ...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~111-~111: Loose punctuation mark.
Context: ... 'https://github.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI...

(UNLIKELY_OPENING_PUNCTUATION)

markdown/blog/conference-2024-summary.md Show resolved Hide resolved
derberg
derberg previously approved these changes Jan 27, 2025
@derberg
Copy link
Member

derberg commented Jan 27, 2025

@quetzalliwrites please review and approve

@thulieblack
Copy link
Member Author

thulieblack commented Jan 28, 2025

I need this PR merged soon, as it must accompany the announcements

Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, the rest looks good to me. Looks Good to me!

CC @quetzalliwrites please confirm the same and merge. Thank you ! @thulieblack

markdown/blog/conference-2024-summary.md Outdated Show resolved Hide resolved
markdown/blog/conference-2024-summary.md Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
markdown/blog/conference-2024-summary.md (2)

75-112: Clean up formatting in Profiles component.

Remove trailing whitespace after some entries (e.g., lines 100, 105) to maintain consistent formatting.

-  }, 
+  },
🧰 Tools
🪛 LanguageTool

[duplication] ~75-~75: Possible typo: you repeated a word.
Context: ...aterials and set up the booth tables. <Profiles profiles={[ { name: 'Lukasz Gornicki', ...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~111-~111: Loose punctuation mark.
Context: ... 'https://github.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI...

(UNLIKELY_OPENING_PUNCTUATION)


115-115: Improve section heading clarity.

The heading "Where To In 2025?" could be more clear. Consider alternatives like:

  • "What's Coming in 2025?"
  • "AsyncAPI Conference Locations for 2025"
  • "2025 Conference Schedule"
🧰 Tools
🪛 LanguageTool

[grammar] ~115-~115: This question appears to miss a verb.
Context: ...ithub.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI Conference 2025, we are ex...

(QUESTION_WITHOUT_VERB)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3db989 and 5c52caa.

📒 Files selected for processing (1)
  • markdown/blog/conference-2024-summary.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
markdown/blog/conference-2024-summary.md

[duplication] ~75-~75: Possible typo: you repeated a word.
Context: ...aterials and set up the booth tables. <Profiles profiles={[ { name: 'Lukasz Gornicki', ...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~111-~111: Loose punctuation mark.
Context: ... 'https://github.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI...

(UNLIKELY_OPENING_PUNCTUATION)


[grammar] ~115-~115: This question appears to miss a verb.
Context: ...ithub.com/ashmit-coder' } ]} /> ## Where To In 2025? For AsyncAPI Conference 2025, we are ex...

(QUESTION_WITHOUT_VERB)

🔇 Additional comments (4)
markdown/blog/conference-2024-summary.md (4)

3-3: Verify the publication date.

The blog post date is set to January 28, 2025, which is in the future. Consider setting it to the current date or a past date when the conference summary was actually written.


26-28: Add alt text for accessibility.

The Figure component is missing an alt text description, which is important for accessibility.


45-45: Verify attendance numbers.

Based on previous discussions, these numbers might be underestimated. Please confirm the final attendance figures for both in-person and online events.


126-129: LGTM! Links and contact information are properly formatted.

The sponsorship prospectus link and email address are correctly formatted.

@thulieblack
Copy link
Member Author

/ptal

@asyncapi-bot
Copy link
Contributor

@thulieblack thulieblack requested a review from derberg January 28, 2025 07:40
@derberg derberg merged commit 921c30e into asyncapi:master Jan 29, 2025
18 checks passed
@thulieblack thulieblack deleted the 2024-conf branch January 29, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants