Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve granular componentization of generator package template #1353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bishoywadea
Copy link

Description

Refactored the generator package template to improve granular componentization. This change breaks down the monolithic client.js.js file into smaller, reusable components such as ClassDeclaration, ConnectMethod, EventHandlerMethods, HandlerRegistration, UtilityMethods, and ModuleExport. This improves readability, maintainability, and reusability of the template code.

Related Issue(s)

Fixes #1349

Copy link

changeset-bot bot commented Jan 30, 2025

⚠️ No Changeset found

Latest commit: f4d6afa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Bishoywadea
Copy link
Author

@derberg any feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

continue componentization of existing client: packages/templates/clients/js/websocket/template/client.js.js
1 participant