Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue componentization of existing client: packages/templates/clients/js/websocket/template/client.js.js #1349

Open
derberg opened this issue Jan 29, 2025 · 1 comment · May be fixed by #1353
Labels
enhancement New feature or request

Comments

@derberg
Copy link
Member

derberg commented Jan 29, 2025

Large part of https://github.com/asyncapi/generator/blob/master/packages/templates/clients/js/websocket/template/client.js.js is still "hardcoded" inside main fail. We should aim for granular componentization - but of course not because we need it, but of course we should do it only if it makes sense.

you can already see FileHeaderInfo and Requires there in action. Check the rest and propose new components.

remember they are like functions. So you do not want to have all the code in one function, with possible repetitions, and instead you devide your code into sections and push to components.

reading client.js.js should be super easy, you shoudl be able to understand what details it contains without really knowing exactly the entire code.

I hope that it makes sense

@derberg derberg converted this from a draft issue Jan 29, 2025
@derberg derberg added the enhancement New feature or request label Jan 29, 2025
@Bishoywadea
Copy link

iam working on this @derberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants