Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleaned config files #542

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

Aryan4884
Copy link
Contributor

Issue: #534

Description
Removed old references in the config files.Also left the title body as it was to enter the new data more conveniently.

Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for peaceful-ramanujan-288045 failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 431af50
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6795589b8ae3cf00089b2245

@Aryan4884 Aryan4884 changed the title Clear config files fix: clear config files Jan 25, 2025
@Aryan4884 Aryan4884 changed the title fix: clear config files fix: cleaned config files Jan 25, 2025
Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for peaceful-ramanujan-288045 failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit e34bf6b
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/679558a65b049b0008f2f6ea

@Aryan4884
Copy link
Contributor Author

@ashmit-coder Do we need to address all the issues for merging of this PR?As most of the issues are related to Cypress and Netlify deployment function which are getting generated due to removed/missing data during the clean up.

@ashmit-coder
Copy link
Collaborator

@ashmit-coder Do we need to address all the issues for merging of this PR?As most of the issues are related to Cypress and Netlify deployment function which are getting generated due to removed/missing data during the clean up.

yes you have to @Aryan4884

@Aryan4884
Copy link
Contributor Author

@ashmit-coder Can you please review the final changes?

@Aryan4884
Copy link
Contributor Author

@ashmit-coder I haven't suppressed the cypress tests.I just left what needed for the test to get pass and removed other data for new entry.Is it fine ?

@thulieblack
Copy link
Member

/ptal

@asyncapi-bot
Copy link
Contributor

@AceTheCreator @thulieblack @ashmit-coder @Mayaleeeee Please take a look at this PR. Thanks! 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants