-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gallery component for landing page #528
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
one more to add, what is the use case of the button? are we making a dedicated page for the gallery? if yes we have to create a new route for that and if no, i don't think the button is necessary here. it is not doing anything. cc @om2137 @ashmit-coder @AceTheCreator |
In #264 there are two approaches suggested for the button. I have also listed them in PR description. |
Description
Result with new images from slack in Gallery component.
let me know, will make the necessary changes
CC: @ashmit-coder @Mayaleeeee let me know if there are any changes to made.
Related issue
Resolves #264