Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gallery component for landing page #528

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

om2137
Copy link

@om2137 om2137 commented Jan 20, 2025

Description

gallery
Result with new images from slack in Gallery component.

  • Used instead of next's component because with the grid was not behaving as desired.
  • What should be the behaviour of browse button.
    • Redirect to a new page/open modal with all the images/videos, we can list them from Cloudianry.
    • Redirect to a Google Drive link.
      let me know, will make the necessary changes

CC: @ashmit-coder @Mayaleeeee let me know if there are any changes to made.

Related issue
Resolves #264

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 25af5c4
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67922bb43532930008006a7e
😎 Deploy Preview https://deploy-preview-528--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@om2137 om2137 changed the title Gallery component for landing page gallery component for landing page Jan 20, 2025
@om2137 om2137 changed the title gallery component for landing page feat: gallery component for landing page Jan 20, 2025
@om2137 om2137 requested a review from TenzDelek January 21, 2025 07:42
@TenzDelek
Copy link
Contributor

one more to add, what is the use case of the button? are we making a dedicated page for the gallery? if yes we have to create a new route for that and if no, i don't think the button is necessary here. it is not doing anything. cc @om2137 @ashmit-coder @AceTheCreator

@om2137
Copy link
Author

om2137 commented Jan 21, 2025

one more to add, what is the use case of the button? are we making a dedicated page for the gallery? if yes we have to create a new route for that and if no, i don't think the button is necessary here. it is not doing anything. cc @om2137 @ashmit-coder @AceTheCreator

In #264 there are two approaches suggested for the button. I have also listed them in PR description.

@ashmit-coder
Copy link
Collaborator

ashmit-coder commented Jan 22, 2025

Hey @Mayaleeeee could you look into this pr!

The changes look good to me, just inform @om2137 of the functionality of the button or shall it be discarded.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful changes @om2137, but i think it should come after the speakers section.

I think the browse button is pretty cool. @thulieblack, i think you mentioned a public drive link where all the conference media can be accessible. do you mind sharing it?

@om2137
Copy link
Author

om2137 commented Jan 28, 2025

Beautiful changes @om2137, but i think it should come after the speakers section.

I think the browse button is pretty cool. @thulieblack, i think you mentioned a public drive link where all the conference media can be accessible. do you mind sharing it?

@AceTheCreator thankyou, will place the gallery component after speakers section and will add redirection to the drive link once link is available.

@om2137 om2137 requested a review from AceTheCreator January 29, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Gallery Section to AACoT'24 Conference Website
4 participants