Merge pull request #20 from jeffjennings/download_text

More verbose 'download' text on website tutorial pages
astropy · Oct 30, 2024 · ffa9c8b · ffa9c8b
2 parents 608a1f8 + 6338722
commit ffa9c8b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/nbcollection/themes/learnastropy/templates/html/astropy-header.html.j2 b/nbcollection/themes/learnastropy/templates/html/astropy-header.html.j2
@@ -12,7 +12,7 @@
     <a href="{{ resources['learn_astropy_source_url'] }}">{{ resources["learn_astropy_source_label"] or "View on GitHub" }}</a>
     {% endif %}
     {% if resources.learn_astropy_ipynb_download_url %}
-    <a href="{{ resources['learn_astropy_ipynb_download_url'] }}" download>Download</a>
+    <a href="{{ resources['learn_astropy_ipynb_download_url'] }}" download>Download this notebook</a>
     {% endif %}
   </nav>
 </header>
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -147,7 +147,7 @@ def test_learn_astropy_theme(tmp_path):
     assert github_link.attrs["href"] == (
         "https://github.com/astropy/astropy-tutorials/blob/main/tutorials/notebook1.ipynb"
     )
-    download_link = header_nav.find("a", string="Download")
+    download_link = header_nav.find("a", string="Download this notebook")
     assert download_link.attrs["href"] == "notebook1.ipynb"