Support pathlib.Path in write_if_different and import_file

[astrofrog]

Replacement for #83 which includes tests

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.98%. Comparing base (fbd3ba0) to head (c5c51ff).
Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
extension_helpers/_utils.py	90.90%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   75.98%   75.98%           
=======================================
  Files           4        4           
  Lines         329      329           
=======================================
  Hits          250      250           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[neutrinoceros]

@astrofrog Looks like we both worked on this at the very same time (#85) !
My PR looks simpler though, what do you think ?

[astrofrog]

@neutrinoceros - we need to keep supporting str input for those functions, hence some of the changes I made here, and I've also been able to simplify a little of the code using read_bytes/write_bytes. I've also updated the docstrings. The tests here also check both str and Path work, so I'd prefer to keep #84 and close #85 if you agree.

[neutrinoceros]

The tests here also check both str and Path work, so I'd prefer to keep #84 and close #85 if you agree.

I didn't drop support for str in my PR, and I also have tests for both path flavors, so both PRs are pretty much equivalent there, but yours does have additional documentation change so it should probably be favored, yes.
My one critic here is that you're changing the name of an argument that's keyword-allowed, which seems like an unwarranted breaking change.

[astrofrog]

I didn't drop support for str in my PR

Sorry I wrote my comment before you pushed some additional changes 😅 - race conditions!

[neutrinoceros]

This is the breaking change I was talking about. Can you please revert it ? Beyond that, happy to approve this PR.

[astrofrog]

Done and pushed

[astrofrog]

@neutrinoceros - are you happy with this now?

[neutrinoceros]

Absolutely. Thank you !