Fix InvalidTableError for DI_STARS_EXEP and TD tables in ipac.nexsci.nasa_exoplanet_archive

[rickynilsson]

Fixes issue #3090. Line 233 was comparing a table name already converted to lower case with a list of original table names (both upper and lower case). Now comparing lower case throughout.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.62%. Comparing base (24bcb2d) to head (a10f569).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3189   +/-   ##
=======================================
  Coverage   67.62%   67.62%           
=======================================
  Files         229      229           
  Lines       18594    18594           
=======================================
  Hits        12574    12574           
  Misses       6020     6020           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bsipocz]

I would say add the example from the bug report to the test suite and this is good to go.

NasaExoplanetArchive.query_criteria(table='DI_STARS_EXEP', select='*')

[rickynilsson]

Thanks, @bsipocz! I didn't have time to get to it before I left the office today, but it was on my list for tomorrow. :)

[bsipocz]

Ahh, sorry. I want to cut 0.4.9 either tonight or early tomorrow, so just figured there is not much point nitpicking on this instead of just pushing it through the finish line.

[bsipocz]

Damn, I should not have rushed this merge, apparently a couple of remote data tests are failing now :(

[bsipocz]

This messes up the keplertimeseries queries. I feel that is an important enough case that I won't include this PR in the 0.4.9 release.

(Weirdly, this also generates a test failure with the regression test I added in the PR, all the while the query runs without issues in a python terminal).