Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alfalfa: add some tests to increase test coverage from 95 to 100 percent #2886

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

alteholz
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Nov 27, 2023

Hello @alteholz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-27 18:23:02 UTC

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebf4c48) 66.52% compared to head (a681d3f) 66.53%.
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2886      +/-   ##
==========================================
+ Coverage   66.52%   66.53%   +0.01%     
==========================================
  Files         235      235              
  Lines       18101    18101              
==========================================
+ Hits        12041    12044       +3     
+ Misses       6060     6057       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alteholz alteholz changed the title add some tests to increase test coverage from 95 to 100 percent alfalfa: add some tests to increase test coverage from 95 to 100 percent Nov 29, 2023
@bsipocz bsipocz added this to the v0.4.7 milestone Dec 8, 2023
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alteholz! I would generally say going for 100% is counter intuitive, at this point the most beneficial thing would be to add some tests that don't mock the server, but actually test against it.

OTOH, we also have this issue of potentially deprecating alfalfa, so I would not pour much efforts into this module: #1285

@bsipocz bsipocz merged commit 5600762 into astropy:main Dec 8, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants