TST: parametrize surveys to see which one fails

astropy · Dec 20, 2023 · 94cf2b1 · 94cf2b1
1 parent 9387c45
commit 94cf2b1
Showing 1 changed file with 14 additions and 15 deletions.
diff --git a/astroquery/eso/tests/test_eso_remote.py b/astroquery/eso/tests/test_eso_remote.py
@@ -157,29 +157,28 @@ def test_each_instrument_SgrAstar(self, tmp_path):
             else:
                 assert len(result) > 0
 
-    def test_each_survey_and_SgrAstar(self, tmp_path):
+    @pytest.mark.parametrize("survey", Eso().list_surveys(cache=False))
+    def test_each_survey_and_SgrAstar(self, tmp_path, survey):
         eso = Eso()
         eso.cache_location = tmp_path
         eso.ROW_LIMIT = 5
 
-        surveys = eso.list_surveys(cache=False)
-        for survey in surveys:
-            if survey in SGRA_SURVEYS:
+        if survey in SGRA_SURVEYS:
+            result_s = eso.query_surveys(surveys=survey, coord1=266.41681662,
+                                         coord2=-29.00782497,
+                                         box='01 00 00',
+                                         cache=False)
+            assert len(result_s) > 0
+        else:
+            with pytest.warns(NoResultsWarning):
                 result_s = eso.query_surveys(surveys=survey, coord1=266.41681662,
                                              coord2=-29.00782497,
                                              box='01 00 00',
                                              cache=False)
-                assert len(result_s) > 0
-            else:
-                with pytest.warns(NoResultsWarning):
-                    result_s = eso.query_surveys(surveys=survey, coord1=266.41681662,
-                                                 coord2=-29.00782497,
-                                                 box='01 00 00',
-                                                 cache=False)
-                    assert result_s is None
-
-                    generic_result = eso.query_surveys(surveys=survey)
-                    assert len(generic_result) > 0
+                assert result_s is None
+
+                generic_result = eso.query_surveys(surveys=survey)
+                assert len(generic_result) > 0
 
     def test_mixed_case_instrument(self, tmp_path):
         eso = Eso()