Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix style and add changelog
Browse files Browse the repository at this point in the history
zoghbi-a committed Jan 16, 2025
1 parent 6478dfb commit 80cee85
Showing 2 changed files with 14 additions and 1 deletion.
12 changes: 12 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -13,6 +13,18 @@ Infrastructure, Utility and Other Changes and Additions
-------------------------------------------------------


0.4.9 (TBD)
===========

Service fixes and enhancements
------------------------------

heasarc
^^^^^^^

- Fix Heasarc.download_data for Sciserver. [#3183]



0.4.8 (2025-01-16)
==================
3 changes: 2 additions & 1 deletion astroquery/heasarc/tests/test_heasarc.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Licensed under a 3-clause BSD style license - see LICENSE.rst

import os
import shutil
import pytest
import tempfile
from unittest.mock import patch, PropertyMock
@@ -304,6 +303,7 @@ def test_download_data__missingcolumn(host):
):
Heasarc.download_data(Table({"id": [1]}), host=host)


def test_download_data__sciserver():
with tempfile.TemporaryDirectory() as tmpdir:
datadir = f'{tmpdir}/data'
@@ -321,6 +321,7 @@ def test_download_data__sciserver():
assert os.path.exists(f'{downloaddir}/data')
assert os.path.exists(f'{downloaddir}/data/file.txt')


def test_download_data__outside_sciserver():
with pytest.raises(
FileNotFoundError,

0 comments on commit 80cee85

Please sign in to comment.