Only parse roles.json on Team page + other fixes #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
force-pushed
the
fix-console-error
branch
from
dc9e2e0 to
2e2bf32
Compare
pllim
force-pushed
the
fix-console-error
branch
from
0cc3955 to
5186607
Compare
|
@lwasser , I think the listing is good now with this patch. Just in case you are interested. Feel free to unsubscribe if not. Thanks! |
pllim
changed the title
|
thanks for pinging me, @pllim. It's helpful for me to see how things work on this side!! so I'm happy to stay subscribed!! 🚀 |
hamogu
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like every page is trying to read
roles.json. This even results in error in console log becauseaffiliated/index.htmlcannot findroles.jsonin its own directory. Really only the Team page should be parsingroles.json.Also fix #642
And fix an error on History page (lol).