Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leading zeros in tag to make tag consistent with PyPI release #28

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Remove leading zeros in tag to make tag consistent with PyPI release #28

merged 1 commit into from
Sep 12, 2024

Conversation

astrofrog
Copy link
Member

Fixes #17

@astrofrog
Copy link
Member Author

CI failure unrelated, fixed in #29

@pllim
Copy link
Member

pllim commented Sep 10, 2024

I merged #29. Please rebase. Thanks!

@pllim
Copy link
Member

pllim commented Sep 10, 2024

No one (especially astropy) is relying on the leading zeroes in some sort of pattern grepping, right?

@astrofrog
Copy link
Member Author

I doubt it since the release on PyPI don't have the leading zeros. It's only the tags here.

@pllim pllim mentioned this pull request Sep 10, 2024
Merged
@astrofrog astrofrog force-pushed the remove-leading-zeros-from-tag branch from 50160bf to 80bb36f Compare September 12, 2024 09:45
@astrofrog
Copy link
Member Author

Rebased

@astrofrog
Copy link
Member Author

I'll merge and try it out

@astrofrog astrofrog merged commit ebaa5f1 into astropy:main Sep 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiopasra sergiopasra Awaiting requested review from sergiopasra

@pllim pllim Awaiting requested review from pllim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tags are inconsistent with PyPI versions
2 participants
@astrofrog @pllim